Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: solves eth_createAccessList unmarshaling error #524

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

sebaespindola
Copy link
Contributor

Description

Solves #520.

This is a fix for the unmarshaling error that was encountered on version 1.101500.0
The signature of the CreateAccessList method was modified and the state was removed.

Tests
The tests were executed and they have the same results as in the optimism branch.

Additional context

Metadata

Fixes #520

@sebaespindola sebaespindola requested a review from a team as a code owner February 25, 2025 20:37
@sebaespindola
Copy link
Contributor Author

I had previously replaced the state in the AccessList method call with a nil by mistake.
I'm getting the state with a call to StateAndHeaderByNumberOrHash and passing it back to AccessList now.

@sebaespindola
Copy link
Contributor Author

@protolambda sorry to bother you, but if you could review again this PR when you have some time, that would be great.
The nulification of the state in the CreateAccessList method that you noted and requested changes is now fixed.

Thanks!

protolambda
protolambda previously approved these changes Mar 5, 2025
@protolambda
Copy link
Collaborator

Upon closer inspection the original headerByNumberOrHash call was turning generic errors in ethereum.NotFound for API purposes. I changed it to preserve that behavior.
And the AccessList method itself was already retrieving the state, so there is no point in retrieving the state twice.

Updated the PR to fix these. We can squash-merge the results to cleanup the git history churn.

cc @sebastianst for review of these new changes.

@protolambda protolambda dismissed their stale review March 5, 2025 11:04

Needed minor fix to preserve error type and not retrieve state twice.

@protolambda protolambda merged commit ebfc2a5 into ethereum-optimism:optimism Mar 5, 2025
5 of 7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unmarshalling error on eth_createAccessList
3 participants