This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Add --evmc program option #4771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winsvega
reviewed
Jan 15, 2018
| }; | ||
|
|
||
| auto vmOpts = vmProgramOptions(); | ||
| po::parsed_options parsed = po::command_line_parser(argc, argv) |
There was a problem hiding this comment.
how do I get back parsed vm option from Options::get() ?
There was a problem hiding this comment.
You don't. This is only to handle the VM options in single place (VMFactory.cpp). I don't care about the rest of the options. There was a PR introducing program_options in testeth, why is it not merged yet?
There was a problem hiding this comment.
I believe it was in gihub issue
axic
reviewed
Jan 15, 2018
| /// The additional parser for EVM-C options. The options should look like | ||
| /// `--evmc name=value` or `--evmc=name=value`. The boost pass the strings | ||
| /// of `name=value` here. This function splits the name and value or reports | ||
| /// the syntax error if the `=` character is missing. |
There was a problem hiding this comment.
How to pass multiple keys? --evmc debug=true --evmc tracing=true ?
Codecov Report
@@ Coverage Diff @@
## develop #4771 +/- ##
===========================================
+ Coverage 60.61% 60.79% +0.17%
===========================================
Files 347 347
Lines 27290 27333 +43
Branches 2847 2848 +1
===========================================
+ Hits 16543 16617 +74
+ Misses 9750 9728 -22
+ Partials 997 988 -9 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option expects value like this
--evmc name=value. The option is passed then to an EVM-C instance.