docs: Add storage change status analysis #418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
storage_status
branch
from
f4e07f0 to
e5166fb
Compare
axic
reviewed
Sep 6, 2019
holiman
reviewed
Sep 6, 2019
docs/storage_change_status.md
Outdated
|
|
||
| | Constant | Value | | ||
| | -------- | ----- | | ||
| | SLOAD | 200 | |
There was a problem hiding this comment.
You're using 200 for all of these - but it's 800 no?
There was a problem hiding this comment.
Yes, the unmerged EIP-2200 uses 800, but I wasn't sure the re# 100% confirmed to go though. The precise value is secondary in the context of this document.
There was a problem hiding this comment.
It did go through, eventually, haha :)
axic
reviewed
Sep 19, 2019
|
@chfast can this be merged (without any major changes) or this current version is invalid? |
|
Rebased. And trying updating it with the final Istanbul numbers. The commits can be squashed. |
|
This has doxygen warnings: |
Expand the number of storage statuses to cover all possible EVM behaviors. These provide enough information to VM to compute not only gas costs but also refunds. Including legacy SSTORE costs before net gas metering.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming these is fun...
There are also differences in basic names in EVMC and the EVM spec:
ADDEDvsSET,MODIFIEDvsRESET,DELETEDvsCLEARS.