Baseline API #314
Merged
Baseline API #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 24 24
Lines 3829 3829
=======================================
Hits 3820 3820
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
force-pushed
the
execute_api
branch
2 times, most recently
from
ce3a5ab to
1306ff1
Compare
axic
reviewed
May 4, 2021
| @@ -31,7 +31,7 @@ evmc_set_option_result set_option(evmc_vm* vm, char const* name, char const* val | |||
| { | |||
| if (value[0] == '0' && value[1] == '\0') // O=0 | |||
| { | |||
| vm->execute = evmone::baseline_execute; | |||
| vm->execute = evmone::baseline::execute; | |||
There was a problem hiding this comment.
Nice! Will you also move the other one to the evmone::advanced namesapce?
There was a problem hiding this comment.
It was easy esthetic change, but I don't plan to do it more right now.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.