Advanced: Basic block metadata placement refactoring #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
block-metadata-refactor
branch
3 times, most recently
from
fb32239 to
8036a6b
Compare
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 37 37
Lines 4539 4543 +4
=======================================
+ Hits 4520 4524 +4
Misses 19 19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
force-pushed
the
block-metadata-refactor
branch
5 times, most recently
from
4c25348 to
20486e9
Compare
|
@chfast This currently works by keeping only single Do you think it's worth to try to get rid of this first |
This is fine as a start, but at some point we have to make sure the |
It is always added here now. |
chfast
force-pushed
the
block-metadata-refactor
branch
from
20486e9 to
603327d
Compare
chfast
reviewed
Apr 12, 2022
| @@ -234,6 +235,7 @@ constexpr std::array<instruction_exec_fn, 256> instruction_implementations = []( | |||
| table[OP_PC] = op_pc; | |||
| table[OP_GAS] = op_gas; | |||
| table[OPX_BEGINBLOCK] = opx_beginblock; | |||
| table[OP_JUMPDEST] = opx_beginblock; | |||
There was a problem hiding this comment.
The OPX_BEGINBLOCK is alias for OP_JUMPDEST :)
gumb0
force-pushed
the
block-metadata-refactor
branch
from
603327d to
f7edc0d
Compare
chfast
force-pushed
the
block-metadata-refactor
branch
from
f7edc0d to
b5b09cc
Compare
|
Analysis benchmarks |
|
Execution benchmarks |
gumb0
force-pushed
the
block-metadata-refactor
branch
4 times, most recently
from
c08c338 to
ef7b05e
Compare
chfast
force-pushed
the
block-metadata-refactor
branch
from
290404c to
1c26b64
Compare
chfast
added a commit
that referenced
this pull request
Jun 14, 2022
Fix stack height check for the basic block following a JUMPI instruction. Before the stack height was 1 too big because the implementation incorrectly did not remove the JUMPI condition from the stack. The bug was introduced in #457.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #445