Fix instruction tracing of EOF code #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the size of the executable code section in the analysis result so that the tracer receives correct information about the running code.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #536 +/- ##
==========================================
+ Coverage 97.99% 98.03% +0.03%
==========================================
Files 59 59
Lines 5681 5687 +6
==========================================
+ Hits 5567 5575 +8
+ Misses 114 112 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rodiazet
approved these changes
Dec 6, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #531 tracer gets
state.original_codeand then uses PC value to get an opcode from this code, which is incorrect for EOF.I don't have a fix yet, but wrote a test.