t8n: Add tx hash calculation for tx receipt #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Mar 21, 2023
chfast
requested changes
Mar 22, 2023
rodiazet
force-pushed
the
t8n-improvement
branch
from
ba6791d to
7f07913
Compare
axic
reviewed
Mar 22, 2023
chfast
requested changes
Mar 22, 2023
axic
changed the title
rodiazet
force-pushed
the
t8n-improvement
branch
from
7f07913 to
05a5bd3
Compare
rodiazet
force-pushed
the
t8n-improvement
branch
from
05a5bd3 to
6e3e39b
Compare
chfast
requested changes
Mar 22, 2023
rodiazet
force-pushed
the
t8n-improvement
branch
from
6e3e39b to
317a4a5
Compare
chfast
approved these changes
Mar 22, 2023
axic
reviewed
Mar 22, 2023
| if (loaded_tx_hash_opt != computed_tx_hash) | ||
| throw std::logic_error("transaction hash mismatched: computed " + | ||
| hex0x(computed_tx_hash) + ", expected " + | ||
| hex0x(loaded_tx_hash_opt.value())); |
There was a problem hiding this comment.
Could have used this here, no?
Suggested change
| hex0x(loaded_tx_hash_opt.value())); | |
| hex0x(*loaded_tx_hash_opt)); |
There was a problem hiding this comment.
Merged. I will add new PR if necessary
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execution-spec-tests. The tool doesn't sethashfield for transaction intxs.json. We have to calculate it.