Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Blockchain tests support: Introduce difficulty calculation in t8n #682

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Blockchain tests support: Introduce difficulty calculation in t8n #682

merged 4 commits into from
Sep 1, 2023

Conversation

rodiazet
Copy link
Contributor

@rodiazet rodiazet commented Aug 9, 2023 •
edited
Loading

  • Add ommer block reward
  • Difficulty calculation added
  • Use it in t8n interface implementation

@rodiazet rodiazet requested review from chfast and gumb0 August 9, 2023 13:53
@codecov
Copy link

codecov bot commented Aug 9, 2023 •
edited
Loading

Codecov Report

Merging #682 (ab77bf9) into master (07a371b) will decrease coverage by 0.09%.
The diff coverage is 91.50%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
- Coverage   97.62%   97.54%   -0.09%     
==========================================
  Files          89       91       +2     
  Lines        8382     8473      +91     
==========================================
+ Hits         8183     8265      +82     
- Misses        199      208       +9
Flag Coverage Δ
blockchaintests 63.05% <ø> (ø)
statetests 73.28% <40.35%> (-0.91%) ⬇️
statetests-silkpre 22.82% <24.21%> (-0.08%) ⬇️
unittests 95.42% <91.50%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
test/state/hash_utils.hpp 100.00% <ø> (ø)
test/state/state.hpp 100.00% <ø> (ø)
test/statetest/statetest.hpp 100.00% <ø> (ø)
test/unittests/state_transition.hpp 0.00% <ø> (ø)
test/unittests/state_transition.cpp 93.61% <50.00%> (-2.04%) ⬇️
test/state/ethash_difficulty.cpp 72.41% <72.41%> (ø)
test/state/state.cpp 98.74% <100.00%> (+0.05%) ⬆️
test/statetest/statetest_loader.cpp 91.08% <100.00%> (+0.74%) ⬆️
test/statetest/statetest_runner.cpp 100.00% <100.00%> (ø)
test/unittests/state_difficulty_test.cpp 100.00% <100.00%> (ø)
... and 4 more

chfast
chfast reviewed Aug 15, 2023
View reviewed changes
@rodiazet rodiazet force-pushed the difficulty-t8n branch 3 times, most recently from 855ac74 to b82e07f Compare August 16, 2023 17:17
@rodiazet rodiazet changed the title Blockchain tests fixing: Introduce difficulty calculation in t8n Blockchain tests support: Introduce difficulty calculation in t8n Aug 17, 2023
@rodiazet rodiazet requested a review from chfast August 18, 2023 11:48
@rodiazet rodiazet mentioned this pull request Aug 21, 2023
Closed
@rodiazet rodiazet force-pushed the difficulty-t8n branch 3 times, most recently from d85ec28 to 2c54f0c Compare August 22, 2023 09:04
chfast
chfast reviewed Aug 24, 2023
View reviewed changes
gumb0
gumb0 reviewed Aug 28, 2023
View reviewed changes
gumb0
gumb0 reviewed Aug 29, 2023
View reviewed changes
@chfast
state: Add EmptyListHash constant
e994d20 
Add `state::EmptyListHash` representing the keccak hash
of the empty RLP list.

Init expected logs hash in StateTranstionTest to EmptyListHash.
@chfast chfast mentioned this pull request Aug 30, 2023
Closed
@chfast chfast force-pushed the difficulty-t8n branch 3 times, most recently from 007a48b to b8a6573 Compare August 30, 2023 20:56
@chfast chfast force-pushed the difficulty-t8n branch 2 times, most recently from 83fa073 to cb625cf Compare August 31, 2023 14:17
chfast
chfast reviewed Aug 31, 2023
View reviewed changes
@rodiazet rodiazet force-pushed the difficulty-t8n branch 2 times, most recently from 6744ded to 599fff8 Compare August 31, 2023 14:54
@chfast chfast force-pushed the difficulty-t8n branch 4 times, most recently from 7d0e0ee to 1e1ee65 Compare September 1, 2023 14:40
gumb0
gumb0 reviewed Sep 1, 2023
View reviewed changes
gumb0
gumb0 reviewed Sep 1, 2023
View reviewed changes
@rodiazet rodiazet force-pushed the difficulty-t8n branch 2 times, most recently from ac8b525 to e42a314 Compare September 1, 2023 16:48
@rodiazet rodiazet merged commit 503ec3c into master Sep 1, 2023
@rodiazet rodiazet deleted the difficulty-t8n branch September 1, 2023 17:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@gumb0 gumb0 gumb0 left review comments

@chfast chfast chfast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodiazet @chfast @gumb0