Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement EIP-4788: Beacon block root in the EVM #709

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Implement EIP-4788: Beacon block root in the EVM #709

merged 4 commits into from
Nov 27, 2023

Conversation

chfast
Copy link
Member

@chfast chfast commented Sep 24, 2023

Implement the system call from the "Block processing" of the EIP-4788.
https://eips.ethereum.org/EIPS/eip-4788#block-processing

At the beginning of each block a gas-free call is invoked from
the system account (0xff..fe) to the specific system contract.

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #709 (87e8d9b) into master (2fb7cc1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #709   +/-   ##
=======================================
  Coverage   97.71%   97.72%           
=======================================
  Files         107      108    +1     
  Lines        9746     9784   +38     
=======================================
+ Hits         9523     9561   +38     
  Misses        223      223           
Flag Coverage Δ
blockchaintests 62.23% <ø> (ø)
statetests 60.56% <35.71%> (-0.13%) ⬇️
statetests-silkpre 27.29% <3.03%> (-0.11%) ⬇️
unittests 95.68% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/blockchaintest/blockchaintest.hpp 0.00% <ø> (ø)
test/blockchaintest/blockchaintest_loader.cpp 94.73% <100.00%> (+0.14%) ⬆️
test/state/host.cpp 93.80% <100.00%> (ø)
test/state/state.cpp 100.00% <100.00%> (ø)
test/state/state.hpp 100.00% <ø> (ø)
test/statetest/statetest_loader.cpp 96.13% <ø> (ø)
test/unittests/state_system_call_test.cpp 100.00% <100.00%> (ø)

@chfast chfast added the Cancun Changes for Cancun Ethereum spec revision label Sep 24, 2023
@chfast chfast force-pushed the eip4788 branch 2 times, most recently from c13c88f to a3bace8 Compare September 26, 2023 16:59
@chfast chfast force-pushed the eip4788 branch 3 times, most recently from e638733 to 7532c7d Compare November 24, 2023 10:24
@chfast chfast changed the base branch from master to test_json_loading November 24, 2023 10:27
@chfast chfast marked this pull request as ready for review November 24, 2023 10:28
@chfast chfast force-pushed the test_json_loading branch 2 times, most recently from 952d465 to 78a3bdb Compare November 24, 2023 14:55
Base automatically changed from test_json_loading to master November 24, 2023 15:06
@chfast chfast changed the base branch from master to eip6780_selfdestruct November 24, 2023 16:52
Copy link
Member

@gumb0 gumb0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but unit test fails on sanitizer build

@chfast
Copy link
Member Author

chfast commented Nov 24, 2023

Looks good, but unit test fails on sanitizer build

Noticed, but I don't know why yet.

@chfast chfast force-pushed the eip6780_selfdestruct branch from 2d31f5b to 90f4f80 Compare November 27, 2023 10:08
Base automatically changed from eip6780_selfdestruct to master November 27, 2023 10:21
Implement the system call from the "Block processing" of the EIP-4788.
https://eips.ethereum.org/EIPS/eip-4788#block-processing

At the beginning of each block a gas-free call is invoked from
the _system_ account (0xff..fe) to the specific _system_ contract.
@chfast chfast merged commit b1c9637 into master Nov 27, 2023
@chfast chfast deleted the eip4788 branch November 27, 2023 10:59
@cameel cameel mentioned this pull request Jan 5, 2024
9 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Cancun Changes for Cancun Ethereum spec revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants