Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

state: Implement difficulty calculation for pre Byzantium rev #718

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

rodiazet
Copy link
Contributor

@rodiazet rodiazet commented Oct 9, 2023

  • Support proper difficulty calculation pre Byzantium to make blockchain tests start passing.

@rodiazet rodiazet requested a review from gumb0 October 9, 2023 12:49
@rodiazet rodiazet force-pushed the diff-fix branch 2 times, most recently from 07e6640 to 523bcb6 Compare October 9, 2023 12:54
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #718 (fa79c9f) into master (c1ad6c6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #718      +/-   ##
==========================================
+ Coverage   97.70%   97.71%   +0.01%     
==========================================
  Files         102      102              
  Lines        9404     9417      +13     
==========================================
+ Hits         9188     9202      +14     
+ Misses        216      215       -1     
Flag Coverage Δ
blockchaintests 62.23% <ø> (ø)
statetests 64.70% <0.00%> (-0.29%) ⬇️
statetests-silkpre 26.06% <0.00%> (-0.04%) ⬇️
unittests 95.72% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/state/ethash_difficulty.cpp 83.33% <100.00%> (+10.91%) ⬆️
test/unittests/state_difficulty_test.cpp 100.00% <ø> (ø)

@chfast chfast merged commit 8155010 into master Nov 9, 2023
@chfast chfast deleted the diff-fix branch November 9, 2023 12:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants