Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Local and core ingot support. #1046

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Conversation

g-r-a-n-t
Copy link
Member

@g-r-a-n-t g-r-a-n-t commented Jan 20, 2025

This PR implements the following:

  • resolution of ingots on disk with error handling
  • folder ingot checking (e.g. fe check my/ingot/path)
  • a core ingot that is statically loaded by default and overridable using the --core arg (e.g. fe check my/ingot/path --core my/core/ingot/path)

@g-r-a-n-t g-r-a-n-t force-pushed the core-local-ingots branch 5 times, most recently from b6bcc53 to ca41878 Compare January 24, 2025 17:06
@g-r-a-n-t g-r-a-n-t requested a review from sbillig January 24, 2025 17:34
@g-r-a-n-t
Copy link
Member Author

@sbillig there are still a few minor things that I want to address on this PR, but it's pretty much done

@g-r-a-n-t g-r-a-n-t mentioned this pull request Jan 24, 2025
4 tasks
Copy link
Collaborator

@sbillig sbillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left a couple minor nitpicks. You'll probably run into #1049 if you add real stuff to core and try to use it.

@g-r-a-n-t g-r-a-n-t merged commit 0772d06 into ethereum:master Jan 25, 2025
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants