Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: implement web view for DHT census data #199

Merged
merged 2 commits into from
Nov 25, 2023

Conversation

KolbyML
Copy link
Member

@KolbyML KolbyML commented Nov 25, 2023

fixes: #163

I implemented it so it looks pretty decent on mobile not 100% but nice to have.

image
image
image
image

Here are some pictures

@KolbyML KolbyML self-assigned this Nov 25, 2023
Copy link
Member

@pipermerriam pipermerriam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

<tbody>
{% for enr in enr_list %}
<tr>
<td>{{ enr.raw }}</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be nice to have these link to the actual ENR detail page for ENR records.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will be in my next PR. I want to rewrite the ENR detail's page. But I want this to link to a census snapshot of the routing table with all of the ENR's details.

I also want to list stats on what ENR's in the routing table weren't in the census.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we know what nodes routing table look like we know if it is health

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to write this to visualize an issue mike mentioned on when cartographer was running nodes were returning month old offline nodes. So each census was checking 1800 enrs when only 160ish are on the network which means there is a bug, since clients should gossip enr's of nodes offline non-connected nodes. For context*

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggests that one of the clients has not implemented a recurring liviliness check into their routing table management. This suggests that we want an even more granular "Recursive Find Nodes" which gives detailed sourcing information for each node that is checked in the census, so that we know exactly where we got which ENR so that when there is a node in the census giving us bad nodes, we want to be able to point the finger at those nodes.... and identify what client it is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should fix that ethereum/trin#1036

Kayden told me he is working on improving the enr details page.

I will continue this conversation #198 so we aren't talking between two PR's

@KolbyML KolbyML merged commit 5702b8a into ethereum:master Nov 25, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web view for DHT census data
2 participants