core, core/bloombits: fix some issues in the bloombits chain indexer #31149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor and enhance error handling, improve documentation, and expand test cases. * **cmd/geth/main.go** - Remove redundant license comments. * **core/bloom_indexer.go** - Add error handling for bloom generator initialization. - Add error handling for bloom addition and bitset retrieval. - Fix typo in comment. * **core/chain_indexer_test.go** - Add tests for chain indexer reorg handling. - Add tests for chain indexer pruning. * **core/bloombits/generator_test.go** - Add tests for edge cases in bloom generator. * **core/bloombits/matcher_test.go** - Add tests for edge cases in matcher. * **core/bloombits/scheduler_test.go** - Add tests for edge cases in scheduler. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/ethereum/go-ethereum?shareId=XXXX-XXXX-XXXX-XXXX).
lightclient
reviewed
Feb 11, 2025
fjl
changed the title
|
The bloombits indexer will be removed very soon with #30370. So we don't want to apply this change. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and enhance error handling, improve documentation, and expand test cases.
cmd/geth/main.go
core/bloom_indexer.go
core/chain_indexer_test.go
core/bloombits/generator_test.go
core/bloombits/matcher_test.go
core/bloombits/scheduler_test.go
For more details, open the Copilot Workspace session.