core: reduce load on txindexer from API #31752
Merged
+150
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1na
changed the title
rjl493456442
previously approved these changes
May 2, 2025
|
The error handling for whether the transaction indexer is running is much improved compared to before. SGTM! |
|
Tested the PR on my node. It's fast! |
rjl493456442
previously approved these changes
May 4, 2025
s1na
commented
May 4, 2025
|
With the latest changes. Still apart from some spikes goroutine under control. So IMO it's good to go.
I did notice some blocks taking very long in the logs when the script from #31732 (comment) is running as the node is being hammered with requests. So I can imagine why engine API requests might time out if the OP's node is not as powerful. |
rjl493456442
approved these changes
May 5, 2025
This was referenced May 5, 2025
0g-wh
pushed a commit
to 0g-wh/0g-geth
that referenced
this pull request
May 8, 2025
Fixes ethereum#31732. This logic was removed in the recent refactoring in the txindexer to handle history cutoff (ethereum#31393). It was first introduced in this PR: ethereum#28908. I have tested it and it works as an alternative to ethereum#31745. This PR packs 3 changes to the flow of fetching txs from the API: - It caches the indexer tail after each run is over to avoid hitting the db all the time as was done originally in ethereum#28908. - Changes `backend.GetTransaction`. It doesn't return an error anymore when tx indexer is in progress. It shifts the responsibility to the caller to check the progress. The reason is that in most cases we anyway check the txpool for the tx. If it was indeed a pending tx we can avoid the indexer progress check. --------- Co-authored-by: Gary Rong <garyrong0905@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #31732.
This logic was removed in the recent refactoring in the txindexer to handle history cutoff (#31393). It was first introduced in this PR: #28908.
I have tested it and it works as an alternative to #31745.
Content
This PR packs 3 changes to the flow of fetching txes from the API:
backend.GetTransaction. It doesn't return an error anymore when tx indexer is in progress. It shifts the responsibility to the caller to check the progress. The reason is that in most cases we anyway check the txpool for the tx. If it was indeed a pending tx we can avoid the indexer progress check.