Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

fix and update package.json/npm-shrinkwrap.json #1194

Merged
merged 1 commit into from
Sep 27, 2016

Conversation

luclu
Copy link
Contributor

@luclu luclu commented Sep 24, 2016

fixes #1188, #1208

npm dependency graph was broken, test this via:

  1. uninstall every falsy globally installed module
  2. rm -r node_modules
  3. try to npm install

This PR will:

  1. add unmet deps (tslint@3.15.1, typescript@1.7.3) (npm install --save )
  2. update and cleanup npm-shrinkwrap.json via npm install; npm prune; npm shrinkwrap
    • changes:
      • update version string to 0.8.3
      • add both modules (1.) to package.json
      • updates shrinkwrap's dependency graph
        • removes electron-builder as it is only a development package (--save-dev)

Tested on:

  • mac: mac, linux, win builds
  • linux: linux build

@evertonfraga
Copy link
Member

It worked properly

@evertonfraga evertonfraga merged commit c0d8c75 into ethereum:develop Sep 27, 2016
@luclu luclu deleted the update-npm-shrinkwrap branch October 8, 2016 11:04
@lock
Copy link

lock bot commented Mar 31, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Mar 31, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm install error
2 participants