This repository has been archived by the owner on Sep 5, 2020. It is now read-only.
Fix Mist startup crash due to about:blank page #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…existing to reset their tabs.
|
Same error I had with your other PR unfortunately. Probably my fault thou.. |
| if(!Tabs.findOne('browser')) { | ||
| Tabs.insert({ | ||
| _id: 'browser', | ||
| url: 'about:blank', | ||
| url: 'https://ethereum.org', |
There was a problem hiding this comment.
We will change this to the app catalog when we have one
|
Error is due to node version. My changes require that you are running Node 4 or above. This is the currently LTS release of Node anyway so we should be using it. |
|
@hiddentao should we update the readme including the node >= 4 req? |
|
Actually looks like I'd already put it in, see https://github.com/ethereum/mist/tree/develop README |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the crashes experienced by some OS X users (see #472).
about:blanktoethereum.orgfor default browser tab in Mist.