Warn user at deploy time if contract size above ethereum/EIPs#170 #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
reviewed
Aug 15, 2018
src/app/tabs/run-tab.js
Outdated
| } | ||
|
|
||
| if (selectedContract.contract.object.evm.deployedBytecode.object.length > 24576) { | ||
| modalDialog('Contract code size over limit', yo`<div>Contract creation initialization returns data with length of more than 24576 bytes. The deployment will likely fails.</div>`, |
There was a problem hiding this comment.
could we add a link to the iep too? (as reference to user know what is this limitation for)
There was a problem hiding this comment.
@yann300 -- i've added it ^^
There was a problem hiding this comment.
thanks but i meant as a link in the content of the modal too
bakaoh
force-pushed
the
issue1457
branch
2 times, most recently
from
0b2a49b to
694e311
Compare
|
@yann300 --- anything else i need to do? |
yann300
reviewed
Aug 16, 2018
src/app/tabs/run-tab.js
Outdated
| }) | ||
| } | ||
|
|
||
| if (selectedContract.contract.object.evm.deployedBytecode.object.length > 24576) { |
There was a problem hiding this comment.
object here is hex string.
1 hex string is 1/2 bytes.
so you need to divide by 2 here to get the length in bytes
There was a problem hiding this comment.
@yann300 - thanks, i fixed it
yann300
approved these changes
Aug 20, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1457