Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Properly solve the greedy exception catcher problem #174

Closed
axic opened this issue Jan 5, 2018 · 1 comment
Closed

Properly solve the greedy exception catcher problem #174

axic opened this issue Jan 5, 2018 · 1 comment
Assignees
@axic
Labels
enhancement

Comments

@axic
Copy link
Member

axic commented Jan 5, 2018 •
edited
Loading

Apparently there is a way in Emscripten to disable the "greedy exception catcher": https://github.com/kripken/emscripten/blob/f585dcbc2d929ef8b8bc6813e0710ec3215ac0b1/src/settings.js#L325-L328 (Officially suggested here: emscripten-core/emscripten#5957)

Found by @hugo-dc in ethereumjs/rustbn.js#11

Properly fixes #34, #44 and #113.
@axic
Copy link
Member Author

axic commented Jan 16, 2018

Once compiled with that we could remove this code: https://github.com/ethereum/solc-js/blob/master/solcjs#L9-L11

@axic axic mentioned this issue Feb 9, 2018
Merged
@axic axic self-assigned this Feb 9, 2018
@axic axic removed the in progress label Feb 13, 2018
@motin motin mentioned this issue Oct 21, 2018
Closed
@cameel cameel mentioned this issue Dec 3, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@axic axic

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@axic