New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add cargo flag to avoid generated code catching all exceptions #11

Merged

axic merged 1 commit into ethereumjs:master from hugo-dc:avoid-catch-exit

Jan 5, 2018

Contributor

hugo-dc commented Dec 21, 2017 •

edited by axic

Loading

Add cargo flag to avoid generated code catching all exceptions.

https://github.com/kripken/emscripten/blob/f585dcbc2d929ef8b8bc6813e0710ec3215ac0b1/src/settings.js#L325-L328

Replaces #10. Fixes #9.


          add flag to avoid generated code catching all exceptions

206a88e

hugo-dc mentioned this pull request

Fix uncaught exceptions #10

Closed

axic mentioned this pull request

Properly solve the greedy exception catcher problem ethereum/solc-js#174

Closed

Member

axic commented Jan 5, 2018

@hugo-dc that sounds like a great find! Too bad it is not documented properly in emscripten...

axic approved these changes

View reviewed changes

axic merged commit 4fe3d92 into ethereumjs:master

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet