Switch from web3.js to ethers.js

[codersjj]

Update Code Examples from Using Web3.js to Ethers.js

Resolves: #15759

[github-actions]

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

[matheusaaguiar]

Overall looks good, but I think we should address some questions/suggestions before.

[matheusaaguiar]

Suggested change

	JavaScript code, which uses `ethers.js <https://github.com/ethers-io/ethers.js>`_ to create the ``coin`` contract object,
	JavaScript code, which uses `ethers.js <https://github.com/ethers-io/ethers.js>`_ to create the ``Coin`` contract object,

Here Coin refers to the contract name, not the variable name in the example.

[codersjj]

Here Coin refers to the contract name, not the variable name in the example.

Got it, thanks for clarifying!

[matheusaaguiar]

Also, this is failing because there are trailing whitespaces that needed to be removed in lines 191 and 194

[codersjj]

Also, this is failing because there are trailing whitespaces that needed to be removed in lines 191 and 194

Fixed

[matheusaaguiar]

@codersjj can you rebase and squash the commits, please?

[codersjj]

@codersjj can you rebase and squash the commits, please?

Sure! I've rebased and squashed the commits. However, I noticed an extra merge commit was generated. Is this acceptable, or should I clean it up? Let me know! 😊

[cameel]

Thanks for the contribution! The code looks good overall.

However, the PR does not seem to be addressing #15759 completely (despite the Resolves: #15759 in the description). There are a few more web3.js snippets in the docs and also some mentions of the library.

I don't think it really makes sense to convert just one example and leave everything else as is. Having one in some places and the other in others might be even worse than just leaving it as is.

[cameel]

The original formatting here was more readable. No reason to remove it.

Suggested change

	console.log(`Balances now:\nSender: ${ethers.formatUnits(senderBalance, 18)}\nReceiver: ${ethers.formatUnits(receiverBalance, 18)}`);
	console.log(
	`Balances now:\n` +
	`Sender: ${ethers.formatUnits(senderBalance, 18)}\n` +
	`Receiver: ${ethers.formatUnits(receiverBalance, 18)}`
	);

[cameel]

Note that this is not the only place where we're using web3.js. We have a few more examples/mentions:

• Events
• Micropayment channel example
• Creating contracts

We should probably also mention deprecation in the "Resources" section.

[cameel]

Sure! I've rebased and squashed the commits. However, I noticed an extra merge commit was generated. Is this acceptable, or should I clean it up? Let me know! 😊

Rebasing would have removed the merge commit. I think you must have merged develop on your branch instead of rebasing it on develop. Also, the commits with review fixes do not seem squashed.

[codersjj]

Thanks for the contribution! The code looks good overall.

However, the PR does not seem to be addressing #15759 completely (despite the Resolves: #15759 in the description). There are a few more web3.js snippets in the docs and also some mentions of the library.

I don't think it really makes sense to convert just one example and leave everything else as is. Having one in some places and the other in others might be even worse than just leaving it as is.

Thanks for pointing that out—I completely agree! 🙌 You're right that consistency is key here. I'll go through the docs to find any remaining web3.js snippets/mentions and update them to use ethers.js instead. Appreciate the thorough review, and please feel free to flag any other instances I might miss!