-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adds metering to WASM bytecode as part of conversion process per @axic #397
Conversation
wait why we need a workaround like this. could testeth just compile wasm ? |
Note: @jwasinger's script to compile wast-to-wasm will not be needed once ethereum/aleth#4754 is merged. Also, this PR will not be needed once metering is implemented properly. |
@@ -1,3 +1,6 @@ | |||
[submodule "src/GeneralStateTestsFiller/stEWASMTests/utils/wabt"] | |||
path = src/GeneralStateTestsFiller/stEWASMTests/utils/wabt | |||
url = https://github.com/webassembly/wabt | |||
[submodule "src/GeneralStateTestsFiller/stEWASMTests/utils/wasm-metering"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really need submodule?
mv wat2wasm ../.. | ||
``` | ||
|
||
Install wasm-metering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats wasm-metering?
@winsvega this is all testing code merging into @jwasinger's branch. It is not meant to be merged into master. Please disregard it. |
@lrettig , please squash these commits and I will merge. also can you remove unwanted changes from this PR? A lot of files are touched/changed which are seemingly irrelevant to stated the purpose of this PR |
Working on it |
Integrate @axic's metering tool (wasm-metering) into `convert_wast.py`. Update README. Add metering to convert_wast script, update README, change wasm-metering branch
Squashed, back to you |
@jwasinger can you merge this and push the commits to ewasm/tests ? |
merged here: ewasm@edfcdc9 |
No description provided.