Update trace-recursive-find-content response to match spec changes #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
update-trace-rfc
branch
from
95ca962 to
76bc178
Compare
looks good
|
Holding off on merging this until the spec change gets finalized & merged |
njgheorghita
force-pushed
the
update-trace-rfc
branch
from
9242bd5 to
766bac4
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Changes to the
portal_*TraceRecursiveFindContentendpoint in the specs needed implementation.Fixes #987
How was it fixed?
ContentIdtype fromNodeId->[u8; 32]To-Do