Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Decouple Discovery struct from PortalProtocol #101

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Decouple Discovery struct from PortalProtocol #101

merged 1 commit into from
Sep 13, 2021

Conversation

ogenev
Copy link
Member

@ogenev ogenev commented Sep 9, 2021

Initialize Discovery protocol outside of PortalProtocol struct and pass it as parameter.

@ogenev ogenev force-pushed the refactor-discovery-struct branch from f0744b5 to 64fcaf2 Compare September 9, 2021 15:17
@ogenev ogenev force-pushed the refactor-discovery-struct branch from 64fcaf2 to 114f2f3 Compare September 9, 2021 15:21
@ogenev ogenev mentioned this pull request Sep 10, 2021
Merged
njgheorghita
njgheorghita approved these changes Sep 11, 2021
View reviewed changes
Copy link
Collaborator

@njgheorghita njgheorghita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, yeah as I've been getting into the overlay network implementation, I can see the benefit of splitting this out.

@ogenev ogenev merged commit 5ca3119 into ethereum:master Sep 13, 2021
@ogenev ogenev deleted the refactor-discovery-struct branch September 26, 2021 14:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@njgheorghita njgheorghita njgheorghita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogenev @njgheorghita