Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Programmatically track version number for web3_clientVersion #149

Merged
merged 2 commits into from
Oct 21, 2021

Conversation

njgheorghita
Copy link
Collaborator

Automatically update trin version in web3_clientVersion response

Copy link
Collaborator

@jacobkaufmann jacobkaufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straightforward change. I guess this will use the version from trin-core as opposed to the top-level trin? I don't think that's a problem, but one question that came up is whether we expect all of these packages to upgrade to new versions together?

@njgheorghita
Copy link
Collaborator Author

njgheorghita commented Oct 20, 2021

@jacobkaufmann Good question. Personally, I think so, all versions for all crates should be updated in lockstep.

  1. Imo even though we have many crates, this is still one cohesive project. Theoretically these crates can be used individually, but I struggle to see this happening in any significant manner.
  2. Code changes between releases seem likely to touch every crate. Even when that's not the case, I don't see any harm in updating the version of a subcrate

@carver any thoughts?

@carver
Copy link
Collaborator

carver commented Oct 20, 2021

@jacobkaufmann Good question. Personally, I think so, all versions for all crates should be updated in lockstep.

1. Imo even though we have many crates, this is still one cohesive project. Theoretically these crates can be used individually, but I struggle to see this happening in any significant manner.

2. Code changes between releases seem likely to touch every crate. Even when that's not the case, I don't see any harm in updating the version of a subcrate

@carver any thoughts?

👍🏻 to lock the version numbers to each other, at least for now.

@njgheorghita njgheorghita merged commit 2c59872 into ethereum:master Oct 21, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants