Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(beacon): update LightClientHeader fork version #1554

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

ogenev
Copy link
Member

@ogenev ogenev commented Oct 25, 2024

What was wrong?

Portal bridges are injecting light client bootstraps into beacon testnet with an older fork version (Capella instead of Deneb)

How was it fixed?

  • Update LightClientHeader to support the Deneb fork which will allow correct deserialization for recent bootstraps.
  • Add more light client tests for Deneb.

To-Do

@ogenev ogenev marked this pull request as ready for review October 25, 2024 08:52
@ogenev ogenev self-assigned this Oct 25, 2024
@ogenev ogenev added the beacon network Issue related to portal beacon network label Oct 25, 2024
Copy link
Collaborator

@carver carver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

trin-beacon/src/test_utils.rs Outdated Show resolved Hide resolved
@ogenev ogenev force-pushed the fix-lc-bootstrap-fork branch from f04c6a1 to 93bd74a Compare October 28, 2024 07:14
@ogenev ogenev merged commit 12da3d1 into ethereum:master Oct 28, 2024
9 checks passed
@ogenev ogenev deleted the fix-lc-bootstrap-fork branch October 28, 2024 07:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
beacon network Issue related to portal beacon network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants