Format some logs better

[lithp]

A stab at #150:

Before:

Oct 25 23:42:11.079 DEBUG trin_core::portalnet::events: Got discv5 event NodeInserted { node_id: NodeId { raw: [5, 208, 240, 167, 153, 116, 216, 224, 160, 101, 80, 229, 154, 206, 113, 239, 182, 109, 181, 137, 16, 96, 251, 63, 85, 223, 235, 208, 3, 242, 175, 11] }, replaced: None }    
Oct 25 23:42:11.079 DEBUG trin_core::portalnet::events: Got discv5 event TalkRequest(TalkRequest { id: RequestId([226, 151, 109, 239, 115, 223, 116, 109]), node_address: NodeAddress { socket_addr: 127.0.0.1:4568, node_id: NodeId { raw: [5, 208, 240, 167, 153, 116, 216, 224, 160, 101, 80, 229, 154, 206, 113, 239, 182, 109, 181, 137, 16, 96, 251, 63, 85, 223, 235, 208, 3, 242, 175, 11] } }, protocol: [115, 116, 97, 116, 101], body: [1, 1, 0, 0, 0, 0, 0, 0, 0, 12, 0, 0, 0, 1, 0, 0, 0, 255, 255, 255, 255, 255, 255, 255, 255, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 36, 0, 0, 0, 0, 0, 0, 0], sender: Some(UnboundedSender { chan: Tx { inner: Chan { tx: Tx { block_tail: 0x55c4fe611290, tail_position: 1 }, semaphore: 0, rx_waker: AtomicWaker, tx_count: 2, rx_fields: "..." } } }) })    
Oct 25 23:42:11.079 DEBUG trin_state::events: Got state request TalkRequest { id: RequestId([226, 151, 109, 239, 115, 223, 116, 109]), node_address: NodeAddress { socket_addr: 127.0.0.1:4568, node_id: NodeId { raw: [5, 208, 240, 167, 153, 116, 216, 224, 160, 101, 80, 229, 154, 206, 113, 239, 182, 109, 181, 137, 16, 96, 251, 63, 85, 223, 235, 208, 3, 242, 175, 11] } }, protocol: [115, 116, 97, 116, 101], body: [1, 1, 0, 0, 0, 0, 0, 0, 0, 12, 0, 0, 0, 1, 0, 0, 0, 255, 255, 255, 255, 255, 255, 255, 255, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 36, 0, 0, 0, 0, 0, 0, 0], sender: Some(UnboundedSender { chan: Tx { inner: Chan { tx: Tx { block_tail: 0x55c4fe611290, tail_position: 1 }, semaphore: 0, rx_waker: AtomicWaker, tx_count: 2, rx_fields: "..." } } }) }    
Oct 25 23:42:11.079 DEBUG trin_core::portalnet::overlay: Got overlay ping request Ping(Ping { enr_seq: 1, payload: Some(CustomPayload { data_radius: 18446744073709551615, payload: None }) })    

After:

Oct 25 23:43:02.373 DEBUG trin_core::portalnet::events: Received NodeInserted(node_id=0x2db0..25ea)    
Oct 25 23:43:02.373 DEBUG trin_core::portalnet::overlay: Received Ping(enr_seq=1, radius=18446744073709551615)    
Oct 25 23:43:02.373 DEBUG trin_core::portalnet::overlay: Sending Pong(enr_seq=1, radius=18446744073709551615)    
Oct 25 23:43:02.373 DEBUG trin_state::events: Sending reply: Pong(Pong { enr_seq: 1, payload: Some(CustomPayload { data_radius: 18446744073709551615, payload: None }) })    

[jacobkaufmann]

LGTM. Is it worth standardizing some logging conventions in the contributing guidelines?

[jacobkaufmann]

nit: "unknown" is misspelled.

[njgheorghita]

Looks way better! Just a thought, but if it's not too cumbersome to also include which overlay network the incoming/outgoing messages are on (state/history/etc.) that would be useful imo

[njgheorghita]

Seems like it's worth replicating these changes over in trin-history?

[njgheorghita]

Is it worth standardizing some logging conventions in the contributing guidelines?

For sure! I'm just not sure exactly how / what style we want to go with. But if anybody has thoughts, or an initial structure in mind, go ahead and open a pr and we can continue the discussion there.

[lithp]

@njgheorghita Just pushed ee29540 which tries to add which network each message came in on, the output now looks like this:

Oct 27 13:01:50.079 DEBUG trin_core::portalnet::events: Received NodeInserted(node_id=0x1e0c..8df2)    
Oct 27 13:01:50.079 DEBUG state_network: trin_core::portalnet::overlay: Received Ping(enr_seq=1, radius=18446744073709551615)
Oct 27 13:01:50.079 DEBUG state_network: trin_core::portalnet::overlay: Sending Pong(enr_seq=1, radius=18446744073709551615)
Oct 27 13:01:50.079 DEBUG trin_state::events: Sending reply: Pong(Pong { enr_seq: 1, payload: Some(CustomPayload { data_radius: 18446744073709551615, payload: None }) })

This isn't a trivial change so giving you one last look before merging!

[njgheorghita]

Looks great! lgtm!