Use newly-released eth-trie #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carver
commented
Oct 27, 2021
... eventually. For now, this basically just checks that everything builds.
This comment has been minimized.
This comment has been minimized.
lithp
reviewed
Oct 30, 2021
| } | ||
|
|
||
| fn flush(&self) -> Result<(), Self::Error> { | ||
| Ok(()) |
There was a problem hiding this comment.
woah! does this mean rocksdb does a commit / fsyncs after every operation?
There was a problem hiding this comment.
Yeah, there is some way to do a batch write operation in their API, but I haven't used it yet.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the new eth-trie, and add a
TrieDBthat implements the trie's DB trait for rocksDB.