chore: bump discv5 to 0.9 includes NAT fixes + other improvements #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
changed the title
KolbyML
force-pushed
the
debug-trin-performance
branch
from
f2d3f7d to
0515537
Compare
KolbyML
force-pushed
the
debug-trin-performance
branch
from
0515537 to
7b846e3
Compare
morph-dev
approved these changes
Jan 17, 2025
ogenev
approved these changes
Jan 17, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We are using a fairly old version of discv5 0.4.1 there has been quote a few improvements
How was it fixed?
by bumping the version and updating what is required
sigp/discv5 had a regression when updating from 0.4.1 to 0.5.0 when upgrading from parity rlp to alloy_rlp. I made a fix here, sigp/discv5#276 I have set the cargo.toml to point to my PR for now, we can update to a release when it is merge in. These improvements seem pretty big so I think they are worth getting in