feat: add uTP duration metrics #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogenev
approved these changes
Jan 20, 2025
| use trin_metrics::timer::DiscardOnDropHistogramTimer; | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct OwnedTimedSemaphorePermit { |
There was a problem hiding this comment.
nit: Some doc strings are always nice
KolbyML
force-pushed
the
add-utp-duration-metrics
branch
from
a8b2ac9 to
b001bac
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
For the most part we have no idea into how uTP is performing, are things working right? Idk lets add some metrics
How was it fixed?
add a timer attached to the semaphore. This metric won't include uTP transfers initiated over json-rpc, but I am not really concerned with the uTP transfers over json-rpc