feat: enable WAL mode on sqlite 1.39-1.9xing Trin performance #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
changed the title
|
I want to test it one more time |
|
Hmm looks like I might have gotten something wrong, I am closing the issue for the time being |
KolbyML
changed the title
|
So I improved the benchmark a little and I think the increase is less, but I found the bug Kim was telling me about and it looks pretty serious and I was able to reproduce it 2 times now, so I will debug that first before continuing with this PR |
KolbyML
changed the title
|
Before So it seems like results vary a little but generally we are seeing a 1.4 to 1.9 times more performance, depending on uTP reliability which can hopefully be smoothed out with performance improvements to uTP and stability fixes |
Which bug? Are you saying that bug is related to enabling WAL, or just that dealing with it was a higher priority? |
It isn't related to WAL I was just talking about things I seen well benchmarking, the error is not related to enabling WAL mode and happening either way |
|
@carver ready for a review |
I was referring to running my benchmark I seen some error's Kim was telling me about, they were occurring on Trin master |
carver
approved these changes
Feb 6, 2025
KolbyML
changed the title
oac1771
pushed a commit
to oac1771/trin
that referenced
this pull request
Feb 13, 2025
KolbyML
added a commit
to KolbyML/trin
that referenced
this pull request
Feb 16, 2025
* fix: update bridge rpc localhost ip address (ethereum#1654) * chore: switch discv5 to pull from crates.io again (ethereum#1655) * fix: stop `generate_random_remote_enr` from generating multicast ip's (ethereum#1657) * feat: implement Debug for PingError so messages display (ethereum#1659) * chore(deps): weekly `cargo update` (ethereum#1661) info: syncing channel updates for '1.81.0-x86_64-unknown-linux-gnu' info: latest update on 2024-09-05, rust version 1.81.0 (eeb90cda1 2024-09-04) info: downloading component 'cargo' info: downloading component 'clippy' info: downloading component 'rust-docs' info: downloading component 'rust-std' info: downloading component 'rustc' info: downloading component 'rustfmt' info: installing component 'cargo' info: installing component 'clippy' info: installing component 'rust-docs' info: installing component 'rust-std' info: installing component 'rustc' info: installing component 'rustfmt' Updating git repository `https://github.com/ethereum/utp` From https://github.com/ethereum/utp * [new tag] v0.1.0-alpha.14 -> origin/tags/v0.1.0-alpha.14 * [new tag] v0.1.0-alpha.14 -> v0.1.0-alpha.14 * [new tag] v0.1.0-alpha.10 -> v0.1.0-alpha.10 * [new tag] v0.1.0-alpha.11 -> v0.1.0-alpha.11 * [new tag] v0.1.0-alpha.12 -> v0.1.0-alpha.12 * [new tag] v0.1.0-alpha.13 -> v0.1.0-alpha.13 * [new tag] v0.1.0-alpha.6 -> v0.1.0-alpha.6 * [new tag] v0.1.0-alpha.7 -> v0.1.0-alpha.7 * [new tag] v0.1.0-alpha.8 -> v0.1.0-alpha.8 * [new tag] v0.1.0-alpha.9 -> v0.1.0-alpha.9 Updating git repository `https://github.com/paradigmxyz/reth.git` From https://github.com/paradigmxyz/reth * [new tag] v1.0.8 -> origin/tags/v1.0.8 * [new tag] v1.0.8 -> v1.0.8 * [new tag] v0.1.0-alpha.1 -> v0.1.0-alpha.1 * [new tag] v0.1.0-alpha.10 -> v0.1.0-alpha.10 * [new tag] v0.1.0-alpha.11 -> v0.1.0-alpha.11 * [new tag] v0.1.0-alpha.12 -> v0.1.0-alpha.12 * [new tag] v0.1.0-alpha.13 -> v0.1.0-alpha.13 * [new tag] v0.1.0-alpha.14 -> v0.1.0-alpha.14 * [new tag] v0.1.0-alpha.15 -> v0.1.0-alpha.15 * [new tag] v0.1.0-alpha.16 -> v0.1.0-alpha.16 * [new tag] v0.1.0-alpha.17 -> v0.1.0-alpha.17 * [new tag] v0.1.0-alpha.18 -> v0.1.0-alpha.18 * [new tag] v0.1.0-alpha.19 -> v0.1.0-alpha.19 * [new tag] v0.1.0-alpha.2 -> v0.1.0-alpha.2 * [new tag] v0.1.0-alpha.20 -> v0.1.0-alpha.20 * [new tag] v0.1.0-alpha.21 -> v0.1.0-alpha.21 * [new tag] v0.1.0-alpha.3 -> v0.1.0-alpha.3 * [new tag] v0.1.0-alpha.4 -> v0.1.0-alpha.4 * [new tag] v0.1.0-alpha.5 -> v0.1.0-alpha.5 * [new tag] v0.1.0-alpha.6 -> v0.1.0-alpha.6 * [new tag] v0.1.0-alpha.7 -> v0.1.0-alpha.7 * [new tag] v0.1.0-alpha.8 -> v0.1.0-alpha.8 * [new tag] v0.1.0-alpha.9 -> v0.1.0-alpha.9 * [new tag] v0.2.0-beta.1 -> v0.2.0-beta.1 * [new tag] v0.2.0-beta.2 -> v0.2.0-beta.2 * [new tag] v0.2.0-beta.3 -> v0.2.0-beta.3 * [new tag] v0.2.0-beta.4 -> v0.2.0-beta.4 * [new tag] v0.2.0-beta.5 -> v0.2.0-beta.5 * [new tag] v0.2.0-beta.6 -> v0.2.0-beta.6 * [new tag] v0.2.0-beta.7 -> v0.2.0-beta.7 * [new tag] v0.2.0-beta.8 -> v0.2.0-beta.8 * [new tag] v0.2.0-beta.9 -> v0.2.0-beta.9 * [new tag] v1.0.0 -> v1.0.0 * [new tag] v1.0.0-rc.1 -> v1.0.0-rc.1 * [new tag] v1.0.0-rc.2 -> v1.0.0-rc.2 * [new tag] v1.0.1 -> v1.0.1 * [new tag] v1.0.2 -> v1.0.2 * [new tag] v1.0.3 -> v1.0.3 * [new tag] v1.0.4 -> v1.0.4 * [new tag] v1.0.5 -> v1.0.5 * [new tag] v1.0.6 -> v1.0.6 * [new tag] v1.0.7 -> v1.0.7 Updating git repository `https://github.com/Snowfork/milagro_bls` From https://github.com/Snowfork/milagro_bls * [new ref] HEAD -> origin/HEAD * [new tag] 0.4.1 -> 0.4.1 * [new tag] 0.5.0 -> 0.5.0 * [new tag] 0.5.1 -> 0.5.1 * [new tag] 0.5.2 -> 0.5.2 * [new tag] 0.5.3 -> 0.5.3 * [new tag] 0.6.0 -> 0.6.0 * [new tag] 0.6.1 -> 0.6.1 * [new tag] v0.10.0 -> v0.10.0 * [new tag] v0.11.0 -> v0.11.0 * [new tag] v0.11.1 -> v0.11.1 * [new tag] v0.11.2 -> v0.11.2 * [new tag] v0.3.0 -> v0.3.0 * [new tag] v0.5.2 -> v0.5.2 * [new tag] v0.7.0 -> v0.7.0 * [new tag] v0.9.0 -> v0.9.0 * [new tag] v1.0.0 -> v1.0.0 * [new tag] v1.0.1 -> v1.0.1 * [new tag] v1.1.0 -> v1.1.0 * [new tag] v1.2.0 -> v1.2.0 * [new tag] v1.3.0 -> v1.3.0 * [new tag] v1.4.0 -> v1.4.0 * [new tag] v1.4.1 -> v1.4.1 * [new tag] v1.4.2 -> v1.4.2 * [new tag] v1.5.0 -> v1.5.0 * [new tag] v1.5.1 -> v1.5.1 Updating git repository `https://github.com/ralexstokes/ssz-rs` From https://github.com/ralexstokes/ssz-rs * [new ref] d09f55b4f8554491e3431e01af1c32347a8781cd -> refs/commit/d09f55b4f8554491e3431e01af1c32347a8781cd * [new tag] v0.1.0 -> v0.1.0 * [new tag] v0.2.0 -> v0.2.0 * [new tag] v0.3.0 -> v0.3.0 * [new tag] v0.4.0 -> v0.4.0 * [new tag] v0.5.0 -> v0.5.0 * [new tag] v0.6.0 -> v0.6.0 * [new tag] v0.7.0 -> v0.7.0 Locking 24 packages to latest compatible versions Updating alloy-chains v0.1.57 -> v0.1.58 Updating async-trait v0.1.85 -> v0.1.86 Updating bumpalo v3.16.0 -> v3.17.0 Updating cc v1.2.10 -> v1.2.11 Updating crunchy v0.2.2 -> v0.2.3 Updating dyn-clone v1.0.17 -> v1.0.18 Adding getrandom v0.3.1 Updating httparse v1.9.5 -> v1.10.0 Updating hyper v1.5.2 -> v1.6.0 Updating rustls v0.23.21 -> v0.23.22 Updating rustls-pki-types v1.10.1 -> v1.11.0 Updating ryu v1.0.18 -> v1.0.19 Updating serde_json v1.0.137 -> v1.0.138 Updating string_cache v0.8.7 -> v0.8.8 Updating string_cache_codegen v0.5.2 -> v0.5.3 Updating syn v2.0.96 -> v2.0.97 Updating tempfile v3.15.0 -> v3.16.0 Updating toml_edit v0.22.22 -> v0.22.23 Updating unicode-ident v1.0.15 -> v1.0.16 Adding wasi v0.13.3+wasi-0.2.2 (latest: v0.14.0+wasi-0.2.3) Updating webpki-roots v0.26.7 -> v0.26.8 Removing winnow v0.6.24 Adding winnow v0.6.26 (latest: v0.7.0) Adding winnow v0.7.0 Adding wit-bindgen-rt v0.33.0 (latest: v0.38.0) note: pass `--verbose` to see 201 unchanged dependencies behind latest * chore: bump uTP to fix selective ack bug (ethereum#1663) * chore: remove state nodes from standard release process (ethereum#1665) * feat: add max-radius param with 5% default (ethereum#1647) * feat: disable state network history header validation (ethereum#1667) * feat: update utp-rs dependency (ethereum#1652) * refactor: rename `era2` to `e2ss` (ethereum#1656) * fix: add temporary flag to disable storing headers (ethereum#1668) * fix: add temporary flag to disable storing history content * feat: enable WAL mode on sqlite 1.39-1.9xing Trin performance (ethereum#1662) * chore: bump ethportal-api version to v0.4.1 * chore: cargo update for trin release * chore: fix tempfile and uuid version due to including breaking change in getrandom (ethereum#1669) * chore: pin crunchy to 0.2.2 for Win compatibility (ethereum#1670) Need the patch for all the sub-dependencies * chore(deps): weekly `cargo update` (ethereum#1675) info: syncing channel updates for '1.81.0-x86_64-unknown-linux-gnu' info: latest update on 2024-09-05, rust version 1.81.0 (eeb90cda1 2024-09-04) info: downloading component 'cargo' info: downloading component 'clippy' info: downloading component 'rust-docs' info: downloading component 'rust-std' info: downloading component 'rustc' info: downloading component 'rustfmt' info: installing component 'cargo' info: installing component 'clippy' info: installing component 'rust-docs' info: installing component 'rust-std' info: installing component 'rustc' info: installing component 'rustfmt' Updating git repository `https://github.com/eira-fransham/crunchy` From https://github.com/eira-fransham/crunchy * [new ref] 1bf90cf2d0a8cfcb2c5592275a23ab028dff6468 -> refs/commit/1bf90cf2d0a8cfcb2c5592275a23ab028dff6468 Updating git repository `https://github.com/Stebalien/tempfile` From https://github.com/Stebalien/tempfile * [new tag] v3.15.0 -> origin/tags/v3.15.0 * [new tag] v3.15.0 -> v3.15.0 * [new tag] v2.0.1 -> v2.0.1 * [new tag] v2.1.0 -> v2.1.0 * [new tag] v2.1.1 -> v2.1.1 * [new tag] v2.1.3 -> v2.1.3 * [new tag] v2.1.4 -> v2.1.4 * [new tag] v2.1.5 -> v2.1.5 * [new tag] v2.1.6 -> v2.1.6 * [new tag] v2.2.0 -> v2.2.0 * [new tag] v3.0.0 -> v3.0.0 * [new tag] v3.0.1 -> v3.0.1 * [new tag] v3.0.2 -> v3.0.2 * [new tag] v3.0.3 -> v3.0.3 * [new tag] v3.0.4 -> v3.0.4 * [new tag] v3.0.5 -> v3.0.5 * [new tag] v3.0.6 -> v3.0.6 * [new tag] v3.0.7 -> v3.0.7 * [new tag] v3.0.8 -> v3.0.8 * [new tag] v3.0.9 -> v3.0.9 * [new tag] v3.1.0 -> v3.1.0 * [new tag] v3.10.0 -> v3.10.0 * [new tag] v3.10.1 -> v3.10.1 * [new tag] v3.11.0 -> v3.11.0 * [new tag] v3.12.0 -> v3.12.0 * [new tag] v3.13.0 -> v3.13.0 * [new tag] v3.14.0 -> v3.14.0 * [new tag] v3.2.0 -> v3.2.0 * [new tag] v3.3.0 -> v3.3.0 * [new tag] v3.4.0 -> v3.4.0 * [new tag] v3.5.0 -> v3.5.0 * [new tag] v3.6.0 -> v3.6.0 * [new tag] v3.7.0 -> v3.7.0 * [new tag] v3.7.1 -> v3.7.1 * [new tag] v3.8.0 -> v3.8.0 * [new tag] v3.8.1 -> v3.8.1 * [new tag] v3.9.0 -> v3.9.0 Updating git repository `https://github.com/uuid-rs/uuid` From https://github.com/uuid-rs/uuid * [new tag] 1.12.1 -> origin/tags/1.12.1 * [new tag] 1.12.1 -> 1.12.1 * [new tag] 0.2.0 -> 0.2.0 * [new tag] 0.2.1 -> 0.2.1 * [new tag] 0.2.2 -> 0.2.2 * [new tag] 0.2.3 -> 0.2.3 * [new tag] 0.3.0 -> 0.3.0 * [new tag] 0.3.1 -> 0.3.1 * [new tag] 0.4.0 -> 0.4.0 * [new tag] 0.5.0 -> 0.5.0 * [new tag] 0.6.0 -> 0.6.0 * [new tag] 0.6.0-beta -> 0.6.0-beta * [new tag] 0.6.1 -> 0.6.1 * [new tag] 0.6.2 -> 0.6.2 * [new tag] 0.6.3 -> 0.6.3 * [new tag] 0.6.4 -> 0.6.4 * [new tag] 0.6.5 -> 0.6.5 * [new tag] 0.7.0 -> 0.7.0 * [new tag] 0.7.0-beta -> 0.7.0-beta * [new tag] 0.7.1 -> 0.7.1 * [new tag] 0.7.2 -> 0.7.2 * [new tag] 0.7.3 -> 0.7.3 * [new tag] 0.7.4 -> 0.7.4 * [new tag] 0.8.0 -> 0.8.0 * [new tag] 0.8.1 -> 0.8.1 * [new tag] 1.0.0 -> 1.0.0 * [new tag] 1.0.0-alpha.1 -> 1.0.0-alpha.1 * [new tag] 1.1.0 -> 1.1.0 * [new tag] 1.1.1 -> 1.1.1 * [new tag] 1.1.2 -> 1.1.2 * [new tag] 1.10.0 -> 1.10.0 * [new tag] 1.11.0 -> 1.11.0 * [new tag] 1.11.1 -> 1.11.1 * [new tag] 1.12.0 -> 1.12.0 * [new tag] 1.2.0 -> 1.2.0 * [new tag] 1.2.1 -> 1.2.1 * [new tag] 1.2.2 -> 1.2.2 * [new tag] 1.3.0 -> 1.3.0 * [new tag] 1.3.1 -> 1.3.1 * [new tag] 1.3.2 -> 1.3.2 * [new tag] 1.3.3 -> 1.3.3 * [new tag] 1.3.4 -> 1.3.4 * [new tag] 1.4.0 -> 1.4.0 * [new tag] 1.4.1 -> 1.4.1 * [new tag] 1.5.0 -> 1.5.0 * [new tag] 1.6.0 -> 1.6.0 * [new tag] 1.6.1 -> 1.6.1 * [new tag] 1.7.0 -> 1.7.0 * [new tag] 1.8.0 -> 1.8.0 * [new tag] 1.9.0 -> 1.9.0 * [new tag] 1.9.1 -> 1.9.1 Updating git repository `https://github.com/ethereum/utp` From https://github.com/ethereum/utp * [new tag] v0.1.0-alpha.16 -> origin/tags/v0.1.0-alpha.16 * [new tag] v0.1.0-alpha.16 -> v0.1.0-alpha.16 * [new tag] v0.1.0-alpha.10 -> v0.1.0-alpha.10 * [new tag] v0.1.0-alpha.11 -> v0.1.0-alpha.11 * [new tag] v0.1.0-alpha.12 -> v0.1.0-alpha.12 * [new tag] v0.1.0-alpha.13 -> v0.1.0-alpha.13 * [new tag] v0.1.0-alpha.14 -> v0.1.0-alpha.14 * [new tag] v0.1.0-alpha.15 -> v0.1.0-alpha.15 * [new tag] v0.1.0-alpha.6 -> v0.1.0-alpha.6 * [new tag] v0.1.0-alpha.7 -> v0.1.0-alpha.7 * [new tag] v0.1.0-alpha.8 -> v0.1.0-alpha.8 * [new tag] v0.1.0-alpha.9 -> v0.1.0-alpha.9 Updating git repository `https://github.com/paradigmxyz/reth.git` From https://github.com/paradigmxyz/reth * [new tag] v1.0.8 -> origin/tags/v1.0.8 * [new tag] v1.0.8 -> v1.0.8 * [new tag] v0.1.0-alpha.1 -> v0.1.0-alpha.1 * [new tag] v0.1.0-alpha.10 -> v0.1.0-alpha.10 * [new tag] v0.1.0-alpha.11 -> v0.1.0-alpha.11 * [new tag] v0.1.0-alpha.12 -> v0.1.0-alpha.12 * [new tag] v0.1.0-alpha.13 -> v0.1.0-alpha.13 * [new tag] v0.1.0-alpha.14 -> v0.1.0-alpha.14 * [new tag] v0.1.0-alpha.15 -> v0.1.0-alpha.15 * [new tag] v0.1.0-alpha.16 -> v0.1.0-alpha.16 * [new tag] v0.1.0-alpha.17 -> v0.1.0-alpha.17 * [new tag] v0.1.0-alpha.18 -> v0.1.0-alpha.18 * [new tag] v0.1.0-alpha.19 -> v0.1.0-alpha.19 * [new tag] v0.1.0-alpha.2 -> v0.1.0-alpha.2 * [new tag] v0.1.0-alpha.20 -> v0.1.0-alpha.20 * [new tag] v0.1.0-alpha.21 -> v0.1.0-alpha.21 * [new tag] v0.1.0-alpha.3 -> v0.1.0-alpha.3 * [new tag] v0.1.0-alpha.4 -> v0.1.0-alpha.4 * [new tag] v0.1.0-alpha.5 -> v0.1.0-alpha.5 * [new tag] v0.1.0-alpha.6 -> v0.1.0-alpha.6 * [new tag] v0.1.0-alpha.7 -> v0.1.0-alpha.7 * [new tag] v0.1.0-alpha.8 -> v0.1.0-alpha.8 * [new tag] v0.1.0-alpha.9 -> v0.1.0-alpha.9 * [new tag] v0.2.0-beta.1 -> v0.2.0-beta.1 * [new tag] v0.2.0-beta.2 -> v0.2.0-beta.2 * [new tag] v0.2.0-beta.3 -> v0.2.0-beta.3 * [new tag] v0.2.0-beta.4 -> v0.2.0-beta.4 * [new tag] v0.2.0-beta.5 -> v0.2.0-beta.5 * [new tag] v0.2.0-beta.6 -> v0.2.0-beta.6 * [new tag] v0.2.0-beta.7 -> v0.2.0-beta.7 * [new tag] v0.2.0-beta.8 -> v0.2.0-beta.8 * [new tag] v0.2.0-beta.9 -> v0.2.0-beta.9 * [new tag] v1.0.0 -> v1.0.0 * [new tag] v1.0.0-rc.1 -> v1.0.0-rc.1 * [new tag] v1.0.0-rc.2 -> v1.0.0-rc.2 * [new tag] v1.0.1 -> v1.0.1 * [new tag] v1.0.2 -> v1.0.2 * [new tag] v1.0.3 -> v1.0.3 * [new tag] v1.0.4 -> v1.0.4 * [new tag] v1.0.5 -> v1.0.5 * [new tag] v1.0.6 -> v1.0.6 * [new tag] v1.0.7 -> v1.0.7 Updating git repository `https://github.com/Snowfork/milagro_bls` From https://github.com/Snowfork/milagro_bls * [new ref] HEAD -> origin/HEAD * [new tag] 0.4.1 -> 0.4.1 * [new tag] 0.5.0 -> 0.5.0 * [new tag] 0.5.1 -> 0.5.1 * [new tag] 0.5.2 -> 0.5.2 * [new tag] 0.5.3 -> 0.5.3 * [new tag] 0.6.0 -> 0.6.0 * [new tag] 0.6.1 -> 0.6.1 * [new tag] v0.10.0 -> v0.10.0 * [new tag] v0.11.0 -> v0.11.0 * [new tag] v0.11.1 -> v0.11.1 * [new tag] v0.11.2 -> v0.11.2 * [new tag] v0.3.0 -> v0.3.0 * [new tag] v0.5.2 -> v0.5.2 * [new tag] v0.7.0 -> v0.7.0 * [new tag] v0.9.0 -> v0.9.0 * [new tag] v1.0.0 -> v1.0.0 * [new tag] v1.0.1 -> v1.0.1 * [new tag] v1.1.0 -> v1.1.0 * [new tag] v1.2.0 -> v1.2.0 * [new tag] v1.3.0 -> v1.3.0 * [new tag] v1.4.0 -> v1.4.0 * [new tag] v1.4.1 -> v1.4.1 * [new tag] v1.4.2 -> v1.4.2 * [new tag] v1.5.0 -> v1.5.0 * [new tag] v1.5.1 -> v1.5.1 Updating git repository `https://github.com/ralexstokes/ssz-rs` From https://github.com/ralexstokes/ssz-rs * [new ref] d09f55b4f8554491e3431e01af1c32347a8781cd -> refs/commit/d09f55b4f8554491e3431e01af1c32347a8781cd * [new tag] v0.1.0 -> v0.1.0 * [new tag] v0.2.0 -> v0.2.0 * [new tag] v0.3.0 -> v0.3.0 * [new tag] v0.4.0 -> v0.4.0 * [new tag] v0.5.0 -> v0.5.0 * [new tag] v0.6.0 -> v0.6.0 * [new tag] v0.7.0 -> v0.7.0 Locking 6 packages to latest compatible versions Updating alloy-chains v0.1.58 -> v0.1.59 Updating cc v1.2.12 -> v1.2.13 Adding const_format v0.2.34 Adding const_format_proc_macros v0.2.34 Updating parity-scale-codec v3.6.12 -> v3.7.4 Updating parity-scale-codec-derive v3.6.12 -> v3.7.4 note: pass `--verbose` to see 205 unchanged dependencies behind latest Co-authored-by: ogenev <ogenev@users.noreply.github.com> * feat: remove LegacyHistory store version (ethereum#1674) * refactor: remove unused Distance type (ethereum#1677) * refactor: use util functions for reading from portal-spec-tests submodule (ethereum#1673) * Update `HeaderWithProof` with latest spec changes (ethereum#1672) * fix: update BlockHeaderProof type to match new specs * refactor: rename PreMergeAccumulatorProof -> HistoricalHashesAccumulatorProof * refactor: move updated hwp types to separate module * refactor: apply milos pr suggestions * fix: final pr comments * refactor: update names to be spec compliant for new hwp (ethereum#1678) * fix: remove debug logs from OverlayService::find_enr (ethereum#1679) * chore: bump alloy to 0.11.1 (ethereum#1681) * fix(ci): make dependencies update bot commit under github-actions account --------- Co-authored-by: Nick Gheorghita <nickgheorghita@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Milos Stankovic <82043364+morph-dev@users.noreply.github.com> Co-authored-by: Jason Carver <ut96caarrs@snkmail.com> Co-authored-by: ogenev <ogenev@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
I ran #1660 without profiling
Before using WAL
INFO trin_bench: Finished gossiping blocks in 16m 11s, with 270336 offersAfter enabling WAL
INFO trin_bench: Finished gossiping blocks in 11m 40s, with 270336 offersI am testing with era1 files 1000 to 1010
How was it fixed?
So after enabling WAL the benchmark finish 1.39 times faster or enabling WAL resulted in approximately a 27.91% reduction in time