Configure p2p port and bootnode ENRs via command line #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Network ports are 16-bit unsigned integers
njgheorghita
approved these changes
May 21, 2021
| @@ -6,12 +6,15 @@ use std::ffi::OsString; | |||
| pub struct TrinConfig { | |||
| pub web3_transport: String, | |||
| pub web3_ipc_path: String, | |||
| pub web3_http_port: u32, | |||
| pub web3_http_port: u16, | |||
There was a problem hiding this comment.
Yeah, this is basically like a hangover coming from python land when I'm used to treating all integers as the same type (u32) - need to drink some coffee and sober up here in rust world.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonus: switch the http port to
uint16, which is sufficient for network ports.