STUN support #26
Merged
STUN support #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-r-a-n-t
reviewed
May 28, 2021
carver
force-pushed
the
stun-support
branch
2 times, most recently
from
ecd3be7 to
6b6ecad
Compare
|
@SamWilsn would you mind taking a look at this too? |
SamWilsn
reviewed
May 28, 2021
Cargo.toml
Outdated
| @@ -14,12 +14,14 @@ env_logger = "0.8.2" | |||
| eth2_ssz = "0.1.2" | |||
| eth2_ssz_derive = "0.1.0" | |||
| futures = "0.3.13" | |||
| get_if_addrs = "0.5.3" | |||
There was a problem hiding this comment.
I'm worried that this hasn't been updated in some time. Some alternatives might be heim or interfaces. I think heim is more mature.
There was a problem hiding this comment.
I got stuck on getting async working with heim. If you feel like pairing with me to fix it, that would be cool. Otherwise, I've got an implementation with interfaces ready to go in c2a564c.
There was a problem hiding this comment.
I'm fine with interfaces if you are, but I'm okay with pairing too. I think you'll want to do something like:
use futures_util::stream::TryStreamExt;
let ifaces: Result<Vec<_>, _> = heim::net::nic().try_collect().await;I'd actually have to sit down and give it a go though.
carver
force-pushed
the
stun-support
branch
2 times, most recently
from
51222da to
cf3e942
Compare
Binding to 127.0.0.1 prevents messages from properly sending to a non-loopback address.
This makes it easier to connect two peers locally if global connection is unavailable.
get_if_addrs is probably abandoned, based on lack of changes for more than 3 years.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23