Added protocol param to send_talkreq() #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carver
approved these changes
Aug 16, 2021
SamWilsn
reviewed
Aug 16, 2021
Well uTP uses talk requests subbing in uTP instead of portal in the uTP spec
so overlay messages would use Overlay for example here as well. Then for example This is just an idea, but yeah. The Portal Network is built upon multiple different networks and protocols to my knowledge. |
Yup, totally makes sense! I just haven't looked at the our utp spec in a while :) Next time, feel free to merge after I've given a 👍🏻 and you've resolved any suggestions. I'll merge it now. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I added to one of my branches, but I thought I might as well make a PR for it because I think it will be quite useful for upcoming protocols also my uTP code will use this so I might as well get it in just so it is already there because I might not be PR'ing that for a while longer.