Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add github stale issues action #863

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

njgheorghita
Copy link
Collaborator

@njgheorghita njgheorghita commented Aug 24, 2023

What was wrong?

As I'm combing through our issues list, I'm finding that we don't have the best track record with tracking issues after they've been opened. I've seen a fair number of duplicate issues, outdated bug reports, and issues that were solved but never close.

The Stale Issues Action, introduced here will...

  • Run daily
  • Add a label "Stale" on issues and pull requests after 60 days of inactivity and comment on them
  • Close the stale issues and pull requests after 14 days of inactivity
  • If an update/comment occur on stale issues or pull requests, the stale label will be removed and the timer will restart

The action itself is very customizable, but imo this default is sufficient to start with and we can adjust it as we see fit.

How was it fixed?

Introduced github action

To-Do

  • Add entry to the release notes (may forgo for trivial changes)
  • Clean up commit history

flamingo

@njgheorghita njgheorghita force-pushed the stale-issues branch 2 times, most recently from 547e095 to ffb0d2d Compare August 24, 2023 19:36
@njgheorghita njgheorghita marked this pull request as ready for review August 24, 2023 19:41
@KolbyML
Copy link
Member

KolbyML commented Aug 24, 2023

Just a quick reply not an actual answer.

I think this is a good direction as I can definitly see what you mean about duplicate issues, outdated bug reports, etc. I do think there are "special" issues what should be treated different from this though well the cases are more rare, I do see a special issue tag which would prevent a issue from going stale.

I am fine with whatever happens but I do think this is an interesting precendent.

@njgheorghita
Copy link
Collaborator Author

@KolbyML I'm inclined to mostly agree with you here, so I've added the exempt-issue-labels: "shelf-stable" rule, so any issue labeled "shelf-stable" will be exempt from this bot. (I'm not married to the name at all, just couldn't think of a better name).

I think it'll be a flamingo task to comb all of the recently "stale"d issues and decide whether they're..

  • worth moving to a milestone
  • worth pinging somebody to check on status (which would automatically reset the stale timer)
  • worth adding the "shelf-stable" label

Though my best sense is that we'll really want to avoid using the "shelf-stable" label.

Copy link
Collaborator

@mrferris mrferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea

Though I'd be in favor of lowering the days-before-issue-stale, two months seems a bit past stale to me. What if we make it a multiple of seven too, like 42? Six weeks to staleness, eight weeks to closed automatically.

@njgheorghita njgheorghita force-pushed the stale-issues branch 2 times, most recently from 39ae12f to 178b0e0 Compare September 1, 2023 17:48
@njgheorghita njgheorghita merged commit 5428baf into ethereum:master Sep 1, 2023
@njgheorghita njgheorghita deleted the stale-issues branch September 1, 2023 17:59
@njgheorghita njgheorghita mentioned this pull request Sep 2, 2023
2 tasks
@ogenev
Copy link
Member

ogenev commented Sep 4, 2023

I think this PR needed more discussion across the team, it is quite a significant change in how we handle old issues. I'm not sure if the pros outweigh the cons here and we don't have a well-defined protocol for what to do with the issues marked as stale from the bot.

@njgheorghita
Copy link
Collaborator Author

@ogenev Yeah no problem. It was ready for review for over a week, and I figured that was enough time that people would speak up if there was any opposition. But I do agree if we're not all on board with using the bot, or at least the current configuration, then that's something we should discuss and reach consensus on during a sync.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants