Add windows build instructions #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carver
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Cool, thanks for putting this together!
I would have looked for this under the developer section, under releasing. https://ethereum.github.io/trin/developers/contributing/releases/release_checklist.html#build-the-binary-for-release
Two options that feel reasonable to me:
- Move this to developer release building section (optionally linking this user section to it for now, until we are posting pre-built binaries for use)
- Add a link in the developer release section pointing here. (this is okay, but is probably further from where we want to be eventually, which is keeping these as developer notes)
KolbyML
force-pushed
the
Add-windows-compilation-instructions
branch
from
8f20adb to
30f5e5f
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We had no instructions for compiling windows
How was it fixed?
By writing instructions