Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove protocol info moved to portal-website #954

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

njgheorghita
Copy link
Collaborator

@njgheorghita njgheorghita commented Oct 4, 2023

What was wrong?

I moved most of the protocol descriptions from our book to portal-website in ethereum/portal-website#14

How was it fixed?

Removed redundant info. Left in trin specific jsonrpc api info

To-Do

  • Add entry to the release notes (may forgo for trivial changes)
  • Clean up commit history

@njgheorghita njgheorghita marked this pull request as ready for review October 4, 2023 19:18
Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@njgheorghita njgheorghita force-pushed the remove-book-protocols branch from 7336a90 to 41c196e Compare October 5, 2023 14:18
@njgheorghita njgheorghita merged commit 0e504ea into ethereum:master Oct 5, 2023
@njgheorghita njgheorghita deleted the remove-book-protocols branch October 5, 2023 14:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants