test: post-shanghai block for eth_getBlockByHash #966
Conversation
tests/rpc_server.rs
Outdated
| let value: Value = serde_yaml::from_str(&file).unwrap(); | ||
| let all_blocks = value.as_sequence().unwrap(); | ||
| let post_shanghai = all_blocks.last().unwrap(); | ||
| assert_eq!(post_shanghai["number"], 1751000); |
There was a problem hiding this comment.
The point of this assertion right now is that if someone appends a new block into the yaml file, then this function would start testing a different block. So this assertion is a way of adding some confidence that we're testing the block that we think we are.
It probably makes sense for me to add that comment inline into the code above.
There was a problem hiding this comment.
Now that we're using yaml and comments are supported, seems like it might also be worth a trailing comment at the bottom of the yaml file
tests/rpc_server.rs
Outdated
| let value: Value = serde_yaml::from_str(&file).unwrap(); | ||
| let all_blocks = value.as_sequence().unwrap(); | ||
| let post_shanghai = all_blocks.last().unwrap(); | ||
| assert_eq!(post_shanghai["number"], 1751000); |
There was a problem hiding this comment.
Now that we're using yaml and comments are supported, seems like it might also be worth a trailing comment at the bottom of the yaml file
The previous asset file doesn't have the block body for that block number. Without the body, the test will fail, because it can't retrieve the transactions. Note that this PR change only affects the It should be straightforward to port over more of the older block assets from the same place I got this one (portal-hive), when support for older forks is a priority. |
carver
force-pushed
the
test-json-with-shanghai
branch
from
fe96596 to
b6e0e26
Compare
Importantly, use a header that we have a block body for.
carver
force-pushed
the
test-json-with-shanghai
branch
from
b6e0e26 to
474cf7f
Compare
Importantly, use a header that we have a block body for.
What was wrong?
I didn't have easy access to the block body value for the header I was using for the json getBlock test. Also, our Devconnect target is for post-Shanghai, so that seems the more important era to test right now.
How was it fixed?
Pulled in (plus restructured) part of this file from portal-hive:
simulators/portal-interop/src/test-data/test_data_collection_of_forks_blocks.yamlSplit from #963
To-Do