chore: Sunset towncrier release notes #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogenev
force-pushed
the
sunset-towncrier
branch
from
805ee6c to
145abea
Compare
ogenev
added
the
flamingo
1 task
njgheorghita
approved these changes
Oct 11, 2023
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -5,4 +5,4 @@ | |||
| ### To-Do | |||
|
|
|||
| [//]: # (Stay ahead of things, add list items here!) | |||
| - [ ] Clean up commit history | |||
| - [ ] Clean up commit history and use conventional commits | |||
There was a problem hiding this comment.
I just closed #953 since it requires a 3rd-party orb, usage of which is not authorized (and will not be) on our circleci account. But I do think adding a lint step to our ci build which validates this is better than simply stating that commits should be "conventional" (tracked in #979). Either way, it's not a blocker for this pr and this is great for the time being.
One thing I would change here is to just make this a hyperlink to "https://www.conventionalcommits.org/en/v1.0.0/" for easy reference
| @@ -18,16 +18,22 @@ written. Once things are complete, you can `git reset master` to unstage all | |||
| of the changes you've made, and then re-commit them in small chunks using `git | |||
| add -p`. | |||
|
|
|||
| ## Commit Messages | |||
| ### Commit Messages | |||
There was a problem hiding this comment.
Nice catch that our docs were getting out of date here!
ogenev
force-pushed
the
sunset-towncrier
branch
from
145abea to
5202d69
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Towncrier is not used anymore for generating release notes. We switched to conventional commits and GitHub releases.
How was it fixed?
newsfragmentfolderdocsfolderTo-Do