Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Metropolis: static call #270

Closed
wants to merge 6 commits into from
Closed

Conversation

pirapira
Copy link
Member

This PR introduces ethereum/EIPs#214 and fixes #234 as part of the Metropolis changes.

This is a reincarnation of #237.

This was referenced Mar 23, 2017
Paper.tex Outdated
@@ -826,7 +828,10 @@ \subsection{Execution Environment}
\item $I_v$, the value, in Wei, passed to this account as part of the same procedure as execution; if the execution agent is a transaction, this would be the transaction value.
\item $I_\mathbf{b}$, the byte array that is the machine code to be executed.
\item $I_H$, the block header of the present block.
\item $I_e$, the depth of the present message-call or contract-creation (i.e. the number of {\small CALL}s or {\small CREATE}s being executed at present).
\item $I_e$, the depth of the present message-call or contract-creation
(i.e. the number of {\small CALL}s or {\small CREATE}s being
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spurious new lines.

Paper.tex Outdated
\item $I_e$, the depth of the present message-call or contract-creation
(i.e. the number of {\small CALL}s or {\small CREATE}s being
executed at present).
\item $I_w$, the permission to write to the state.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...to alter make modifications to the state" sounds a little more natural

Copy link
Contributor

@gavofyork gavofyork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor notes, looks good otherwise.

@pirapira
Copy link
Member Author

Addressed the comments.

@pirapira
Copy link
Member Author

I should target master. Because master is the Byzantium version now, where static call should be introduced.

@pirapira pirapira closed this Jan 17, 2018
@pirapira pirapira mentioned this pull request Jan 17, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants