Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Run with the latest tests (ethereumjs-testing to v1.2.3) #368

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

holgerd77
Copy link
Member

Run the VM on the latests tests included in ethereumjs-testing v1.2.3.

The new tests should now be on a greater part ready to be used for Constantinople testing, especially new SSTORE gas price calculations are now included through a complete test refill (consistency/accuracy not confirmed though yet).

@holgerd77 holgerd77 mentioned this pull request Oct 10, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.926% when pulling 502f2d0 on update-tests into f63c5b9 on master.

@holgerd77
Copy link
Member Author

Blockchain tests are currently not working/invalid on Ethereum/tests, see latest discussions on https://gitter.im/ethereum/tests and it is not forseable when this will completely be fixed. I have therefore temporarily disabled blockchain tests as required and will merge, so that we can continue to work on Constantinople.

@holgerd77 holgerd77 merged commit 08b5a93 into master Oct 10, 2018
@holgerd77 holgerd77 deleted the update-tests branch October 10, 2018 21:01
@vpulim vpulim mentioned this pull request Oct 10, 2018
@holgerd77
Copy link
Member Author

Excerpt with the Constantinople test result summary for reference:

1..4776
# tests 4776
# pass  3783
# fail  993

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants