Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace const keywords with var to support ES5 builds #36

Closed
wants to merge 1 commit into from
Closed

Replace const keywords with var to support ES5 builds #36

wants to merge 1 commit into from

Conversation

mohammadrafigh
Copy link

No description provided.

@holgerd77
Copy link
Member

Hi, thanks for the PR, but we are just in the process of using babel for the various ethereumjs libraries to create ES5 distributions, so this probably won't get merged.

I'll prepare a PR for this library soon.

@mohammadrafigh
Copy link
Author

ok cool and thanks.

@holgerd77
Copy link
Member

Hi @mohammadrafigh, I directly added the PR #37. Could you do a short review (optimally with the review function if available to you, eventually from the "Files changed" tab)?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.62% when pulling c6a57f9 on mohammadrafigh:master into 01382b1 on ethereumjs:master.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants