Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bug in coder array error logger #1004

Closed
zemse opened this issue Aug 15, 2020 · 3 comments
Closed

Bug in coder array error logger #1004

zemse opened this issue Aug 15, 2020 · 3 comments
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@zemse
Copy link
Collaborator

zemse commented Aug 15, 2020

I have a function that takes in fixed length array input.

function payToTree(uint32[3] ratio) public;
contractInstance.payToTree([5, 5]); // Error: too many arguments: coder array _rewardRatio (count=3, expectedCount=2, code=UNEXPECTED_ARGUMENT, version=abi/5.0.1)

contractInstance.payToTree([5, 5, 5, 5]); // Error: missing argument: coder array _rewardRatio (count=3, expectedCount=4, code=MISSING_ARGUMENT, version=abi/5.0.1)

I believe the error should be the other way around. May be the expectedCount and count values need to be flipped.

This is definitely not urgent, but just something I noticed.

@ricmoo
Copy link
Member

ricmoo commented Aug 20, 2020

You are absolutely correct. Looking into this now.

@ricmoo
Copy link
Member

ricmoo commented Aug 26, 2020

This should be fixed in 5.0.9.

Try it out and let me know. :)

@ricmoo ricmoo added the fixed/complete This Bug is fixed or Enhancement is complete and published. label Aug 26, 2020
@ricmoo
Copy link
Member

ricmoo commented Aug 26, 2020

Closing this now, if you still have issues though, please re-open.

Thanks! :)

@ricmoo ricmoo closed this as completed Aug 26, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Development

No branches or pull requests

2 participants