signTypedData presents uint as hexadecimal in MetaMask UI

[PierreJeanjacquot]

Hi @ricmoo thank you for the EIP712 integration,

I'm currently looking to move my projects to Signer.signTypedData, everything I need works as expected, except I'm facing a presentational issue when signing data containing uint type with MetaMask.

• uint,...,uint256 are presented to MetaMask's users in hexadecimal format.
• uint are displayed human readable when calling Web3Provider.send('eth_signTypedData_v4', args).

The issue seems to be only presentational as the resulting signature is the same in both cases.

Here is a demo of the issue: https://codesandbox.io/s/gracious-raman-id9cg?file=/src/index.js

[ricmoo]

The JSON-RPC definition of signTypedData is a bit loose in explaining what the payload should look like for values. Currently, I convert everything to a value compatible with results (e.g. quantity for numbers, which is a hex string without any leading zeros). I can make the payload generator return decimal numbers easy enough, but that should be something I would expect the client (i.e. MetaMask) to handle for display logic.

I'll ping them for their opinions and maybe they have better docs as to input value formats. :)

[pcowgill]

Hi @ricmoo, what would you say is the rough timeline for signTypedData leaving the experimental phase in ethers, triggering the renaming from _signTypedData to signTypedData? Thanks!

[ricmoo]

I am not really sure. I think the API is stable. I could probably move it out of experimental any time, but was wondering if I shouldn’t wait for v6 this summer. I’ll be starting that fork in February, then I’ll have a better idea of how long it might take. But I already have my wish list figured out for it. :)

Changing the formatting in metamask is likely quite simple. I want to talk to the MM folks first though, because I think that is something they should handle, in general. The payload should not be implying anything about presentation and it sounds like it is right now. I don’t mind making ethers use decimal and MM also doing it, but MM should be doing it too. :)

I don’t mind it getting done in both places. :)

[ricmoo]

I've verified that MetaMask does this and made a small change (locally) that should expose numbers as decimal.

It's fine if they also replicate this functionality, which I'll suggest to them too.

[ricmoo]

This should be fixed in 5.0.32. Try it out and let me know. :)

[PierreJeanjacquot]

Looks great, thank you @ricmoo! 🎉