Uncaught Exception in namehash.ts

[yoshiwarab]

Describe the bug
While setting up form field validation for an Ethereum address field I ran into a small bug that throws an uncaught error if provider.resolveName is called with a string ending in a "." character. It looks like the bug is ultimately happening in namehash.ts in the namehash function.

ethers.js/packages/hash/src.ts/namehash.ts

Line 36 in d395d16

const label = toUtf8Bytes(nameprep(partition[3]));

The attempt to access the third matching group here throws the error because partition is null because the Partition regex will not match a string ending in ".". Not sure if it makes sense to update the regex to ^((.*)\\.)?([^.]*)$ or add a null check for partition or something else.

Thanks so much for the awesome lib!

[ricmoo]

Oh! Thanks! I’ll look into this right away.

[ricmoo]

Fixed in 5.3.0. Try it out and let me know if you still have any issues.

Thanks! :)