Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Support for null topic in type defs #1499

Closed
wants to merge 1 commit into from
Closed

Add Support for null topic in type defs #1499

wants to merge 1 commit into from

Conversation

deanshelton913
Copy link

Addresses #1434

@deanshelton913 deanshelton913 changed the title Add Support for null topics in bloom filters Add Support for null topic in type defs Apr 23, 2021
@deanshelton913
Copy link
Author

@ricmoo Can you take a look at this when you get a sec? My IDE is throwing shade. I hate needing to force-type my null as strings. :P

@ricmoo ricmoo added investigate Under investigation and may be a bug. minor-bump Planned for the next minor version bump. on-deck This Enhancement or Bug is currently being worked on. labels Apr 23, 2021
@ricmoo
Copy link
Member

ricmoo commented Apr 23, 2021

I'm working on the changes for the next minor bump now. I'll look into this while preparing it.

@ricmoo ricmoo added enhancement New feature or improvement. and removed investigate Under investigation and may be a bug. labels Apr 24, 2021
ricmoo added a commit that referenced this pull request May 14, 2021
@ricmoo
Added support for null entries in EventFilter (#1499).
3bb5fbf
@ricmoo
Copy link
Member

ricmoo commented May 20, 2021 •
edited
Loading

Merged into 5.2.0.

Thanks! :)

@ricmoo ricmoo closed this May 20, 2021
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels May 20, 2021
pull bot pushed a commit to shapeshift/ethers.js that referenced this pull request Jun 4, 2021
@ricmoo @pull
Added support for null entries in EventFilter (ethers-io#1499).
a967132
pull bot pushed a commit to shapeshift/ethers.js that referenced this pull request Jun 4, 2021
@ricmoo @pull
Added support for null entries in EventFilter (ethers-io#1499).
1c09d2b
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. minor-bump Planned for the next minor version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deanshelton913 @ricmoo