Logic Error in provider-jsonrpc.ts line 385 #4851
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also #4837 which is basically the identical fix |
|
OMG. That is an insane bug to still be present. I will look into it ASAP. Thanks! |
ricmoo
added
bug
ricmoo
added a commit
that referenced
this pull request
Oct 10, 2024
|
Thx so much for taking into consideration fixing this issue <3 |
|
This has been fixed in v6.13.4. Please let me know if you still have any issues. Thanks! :) |
ricmoo
added
duplicate
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logical error in src.ts/providers/provider-jsonrpc.ts line 385:
Logical OR Operator (||) Grouping:
The original code had a misplaced parenthesis:
isError(error, "NETWORK_ERROR" || isError(error, "UNSUPPORTED_OPERATION")).
This caused "NETWORK_ERROR" || isError(error, "UNSUPPORTED_OPERATION") to always evaluate to "NETWORK_ERROR" (a truthy value), making the entire condition always true.
Corrected Grouping:
isError(error, "NETWORK_ERROR") || isError(error, "UNSUPPORTED_OPERATION")
Each isError function call should be individually evaluated and then combined using the || operator.
This ensures that the condition checks if the error matches any of the specified error codes correctly.