Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: replace http-serve with serve package #122

Merged
merged 5 commits into from
May 31, 2021

Conversation

matt-mertens
Copy link
Contributor

Replaces the http-serve package to properly handle the single page routing.

Replaces the http-serve package to properly handle the single page routing
@vojtechsimetka
Copy link
Contributor

vojtechsimetka commented May 28, 2021

Thank @matmertz25 , this is great you are doing exactly what I intended here. Please do solve the serve command in bin as well though (that is what makes the bee-dashboard serve work).

https://github.com/ethersphere/bee-dashboard/pull/122/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R16

@liuxingbaoyu
Copy link

Great work!
This should fix them too.

#116
#97
#86
#108

This should be the same problem we encountered. I tested this commit to fix it.
http-party/http-server#525

@liuxingbaoyu
Copy link

liuxingbaoyu commented May 28, 2021

Also on my computer (windows 10), serve build --single --listen 8080 will use Windows Script to run .\serve.js instead of .\node_modules\.bin\serve.cmd.It works fine after I renamed serve.js to main.js.

@vojtechsimetka
Copy link
Contributor

Oh also could you please commit the package-lock.json file as well? We usually install dependencies with npm ci which actually takes the packages definition from the lock file and not the package.json.

matt-mertens and others added 2 commits May 30, 2021 12:45
Co-authored-by: Vojtech Simetka <vojtech@simetka.cz> (+1 squashed commit)
Squashed commits:
[d73baf4] Update serve.js

Co-authored-by: Vojtech Simetka <vojtech@simetka.cz>
@vojtechsimetka vojtechsimetka force-pushed the fix/single-page-routing branch from 5a5b117 to d6d91a0 Compare May 31, 2021 07:54
@vojtechsimetka vojtechsimetka merged commit ba9b498 into master May 31, 2021
@vojtechsimetka vojtechsimetka deleted the fix/single-page-routing branch May 31, 2021 07:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
3 participants