Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

upgrade to solidity 0.6.8 #106

Merged
merged 1 commit into from
May 19, 2020
Merged

upgrade to solidity 0.6.8 #106

merged 1 commit into from
May 19, 2020

Conversation

ralph-pichler
Copy link
Member

@ralph-pichler ralph-pichler commented May 19, 2020

This upgrades all contracts and tools for solidity 0.6.8.

Changes:

  • all tools have been update to versions compatible with 0.6.8.
  • disabling mark-callable-contracts in solhint no longer needed
  • compiler-version solhint check had to be disabled as it expects solidity 0.5.
  • last remnants of ethlint / solium have been removed
  • Uses ERC20PresetMinterPauser as a test token as ERC20Mintable has been removed from openzeppelin.
  • The import for ERC20PresetMinterPauser (to ensure its available during tests) now happens in Migrations.sol so that no test code appears in the main sol files.
  • To ensure binding for ERC20PresetMinterPauser are present for go-side testing in the bindings, go bindings for Migrations are also generated.

@ralph-pichler ralph-pichler requested a review from Eknir May 19, 2020 10:58
@ralph-pichler ralph-pichler changed the title upgrade to solidity 6 upgrade to solidity 0.6.8 May 19, 2020
Copy link
Collaborator

@Eknir Eknir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for doing this maintenance.

@ralph-pichler ralph-pichler merged commit efe312e into master May 19, 2020
@ralph-pichler ralph-pichler deleted the solidity6 branch May 19, 2020 11:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants