migrate to hardhat #121
migrate to hardhat #121
Conversation
ralph-pichler
force-pushed
the
hardhat
branch
2 times, most recently
from
b900284 to
3983353
Compare
There was a problem hiding this comment.
I verified that everything works as expected -- it does. There are some minor issues which may be tackled now, or otherwise considered for a separate issue. I would like @vandot s feedback on .github/workflows before merging.
| @@ -0,0 +1,41 @@ | |||
| name: CI | |||
There was a problem hiding this comment.
I can't review this. Perhaps ask @vandot ?
There was a problem hiding this comment.
same ci as in storage-incentives repo.
There was a problem hiding this comment.
@Eknir syntax and yaml look good, I hope that steps/runs do what is needed
There was a problem hiding this comment.
@ralph-pichler - can this somehow be validated before merging?
There was a problem hiding this comment.
@Eknir yes, you can just check the ci output on this PR
package.json
Outdated
| "abigen": "./abigen/gen.sh ERC20SimpleSwap SimpleSwapFactory Migrations", | ||
| "solhint": "solhint contracts/ERC20SimpleSwap.sol contracts/SimpleSwapFactory.sol", | ||
| "lint": "solhint contracts/ERC20SimpleSwap.sol contracts/SimpleSwapFactory.sol", | ||
| "coverage": "truffle run coverage" |
There was a problem hiding this comment.
Update this? See line 18 of README
There was a problem hiding this comment.
it is updated already.
|
Thanks for addressing my comments. Let's wait for @vandot to approve the github workflows and then it is good to go! |
README.md
Outdated
| ``` | ||
|
|
||
| To also generate coverage information use `npm run coverage` instead. | ||
| To also generate coverage information use `yarn hardhat coverage` instead. |
There was a problem hiding this comment.
fixed. also in ci.
makes our framework here more similar to storage-incentives repo