update to solidity 0.8 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eknir
reviewed
Dec 13, 2021
contracts/ERC20SimpleSwap.sol
Outdated
| @@ -62,7 +56,7 @@ contract ERC20SimpleSwap { | |||
| ); | |||
|
|
|||
| // the EIP712 domain this contract uses | |||
| function domain() internal pure returns (EIP712Domain memory) { | |||
| function domain() internal view returns (EIP712Domain memory) { | |||
| uint256 chainId; | |||
| assembly { | |||
There was a problem hiding this comment.
Solidity 0.8 exposes block.chainid, see: https://docs.soliditylang.org/en/v0.8.0/units-and-global-variables.html
| @@ -85,7 +79,7 @@ contract ERC20SimpleSwap { | |||
| } | |||
|
|
|||
| // recover a signature with the EIP712 signing scheme | |||
| function recoverEIP712(bytes32 hash, bytes memory sig) internal pure returns (address) { | |||
There was a problem hiding this comment.
Could you please explain this change?
There was a problem hiding this comment.
querying the chainid is no longer considered pure in 0.8. as this calls domain(), this function cannot be pure either.
|
While you are upgrading, perhaps it makes sense to sanitize https://github.com/ethersphere/swap-swear-and-swindle/blob/master/package.json as well? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SafeMathdependencyabicoderpragma (this should help with source verification)ERC20dependency withIERC20